Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused cc expiry fields from sf query #237

Merged
merged 3 commits into from Dec 24, 2018
Merged

remove unused cc expiry fields from sf query #237

merged 3 commits into from Dec 24, 2018

Conversation

pvighi
Copy link
Contributor

@pvighi pvighi commented Dec 24, 2018

removing everything but the signed off fields from the cc Expiry tab in :
https://docs.google.com/spreadsheets/d/1pGC_HHE6Ba91j4CEpidtAJPRB3ceIepuWgpuHT-KhQY/edit#gid=243144275

@coveralls
Copy link

coveralls commented Dec 24, 2018 •
edited

Pull Request Test Coverage Report for Build 790

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.277%
Totals Coverage Status
Change from base Build 784: 0.0%
Covered Lines: 1948
Relevant Lines: 2733
💛 - Coveralls

paulbrown1982
paulbrown1982 approved these changes Dec 24, 2018
View reviewed changes
Copy link
Member

@paulbrown1982 paulbrown1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Will let you decide whether to bring across CreatedDate or not, or in another PR, etc.

@paulbrown1982
Copy link
Member

👍

@pvighi pvighi merged commit 42b8b68 into master Dec 24, 2018
@pvighi pvighi deleted the ccExpiryFields branch December 24, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbrown1982 paulbrown1982 paulbrown1982 approved these changes

@jacobwinch jacobwinch Awaiting requested review from jacobwinch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pvighi @coveralls @paulbrown1982