Handle salesforce objects with camelcase names correctly #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvighi
commented
Dec 27, 2018
| @@ -6,8 +6,14 @@ import com.gu.sf_datalake_export.salesforce_bulk_api.BulkApiParams.ObjectName | |||
| import com.gu.util.config.Stage | |||
|
|
|||
| object ExportS3Path { | |||
|
|
|||
| def camelToHyphenCase(camelCaseString: String): String = { | |||
| val beforeUpperCase = "(?=[A-Z])" | |||
There was a problem hiding this comment.
I'm not a big fan of regular expressions but I could not find a better way to do this. This matches a zero length space before an upper case letter so when we split using it the upper case letter is not removed from the resulting parts.
Also, this simple conversion is good enough for all our salesforce object names defined in: https://github.com/guardian/zuora-auto-cancel/blob/master/handlers/sf-datalake-export/src/main/scala/com/gu/sf_datalake_export/salesforce_bulk_api/SfQueries.scala#L18
but would fail for strings with multiple upperCase letters in a row like "AmazonSQSClient"
There was a problem hiding this comment.
I think that's OK. For example we use Card_Expiry not CC_Expiry.
Pull Request Test Coverage Report for Build 796
💛 - Coveralls |
pvighi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing the CardExpiry salesforce export I realised we are not generating the correct bucket names for the export if the name of the salesforce object is in camelcase.
The convention for ophan data lake buckets is to use hyphen case so instead of :
ophan-raw-salesforce-cardExpirywe should be writing to
ophan-raw-salesforce-card-expiry