Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 4XX alarm #245

Merged
merged 1 commit into from Jan 11, 2019
Merged

Remove 4XX alarm #245

merged 1 commit into from Jan 11, 2019

Conversation

jacobwinch
Copy link
Contributor

4XX includes payment errors (402s), which should not trigger alerts.

@jacobwinch
Remove 4XX alarm
9321990 
4XX includes payment errors (402s), which should not trigger alerts.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 821

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.231%
Totals Coverage Status
Change from base Build 819: 0.0%
Covered Lines: 1956
Relevant Lines: 2746
💛 - Coveralls

@johnduffell
Copy link
Member

👍 makes sense, as these should be dealt with at the SF level

@jacobwinch jacobwinch merged commit 312e3e8 into master Jan 11, 2019
@jacobwinch jacobwinch deleted the jw-remove-alarm branch January 11, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnduffell johnduffell Awaiting requested review from johnduffell

@mariogalic mariogalic Awaiting requested review from mariogalic

@twrichards twrichards Awaiting requested review from twrichards

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobwinch @coveralls @johnduffell