Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single cancellation reason in Salesforce subscriptions export #246

Merged
merged 1 commit into from Jan 21, 2019
Merged

Single cancellation reason in Salesforce subscriptions export #246

merged 1 commit into from Jan 21, 2019

Conversation

mariogalic
Copy link
Contributor

Related PR: https://github.com/guardian/ophan-data-lake/pull/3294

Reason_for_Cancellation__c covers all cancellations and should map to cancellation_reason in clean.salesforce_subscription.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 824

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.231%
Totals Coverage Status
Change from base Build 822: 0.0%
Covered Lines: 1956
Relevant Lines: 2746
💛 - Coveralls

@mariogalic mariogalic merged commit c3b2426 into master Jan 21, 2019
@mariogalic mariogalic deleted the sf-export-have-single-cancellation-reason branch January 21, 2019 10:07
@johnduffell
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobwinch jacobwinch jacobwinch approved these changes

@paulbrown1982 paulbrown1982 Awaiting requested review from paulbrown1982

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mariogalic @coveralls @johnduffell @jacobwinch