Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct debit mandate failure emails #247

Merged
merged 5 commits into from Jan 24, 2019

Conversation

mariogalic
Copy link
Contributor

@mariogalic mariogalic commented Jan 22, 2019

https://trello.com/c/fU7a3xTf/111-send-direct-debit-failure-emails

Salesforce will POST:

       {  
          "payload":{  
             ...
             "email_stage": MF1 | MF2 | ... | MF8
          },
          "object_name":"DD_Mandate_Failure__c"
       }

which we map to

      case ("DD_Mandate_Failure__c", "MF1") => "dd-mandate-failure-1"
      case ("DD_Mandate_Failure__c", "MF2") => "dd-mandate-failure-2"
      case ("DD_Mandate_Failure__c", "MF3") => "dd-mandate-failure-3"
      case ("DD_Mandate_Failure__c", "MF4") => "dd-mandate-failure-4"
      case ("DD_Mandate_Failure__c", "MF5") => "dd-mandate-failure-5"
      case ("DD_Mandate_Failure__c", "MF6") => "dd-mandate-failure-6"

which membership-workflow maps to corresponding Braze Campaign API Identifier:

Related PR: https://github.com/guardian/membership-workflow/pull/170

@coveralls
Copy link

coveralls commented Jan 22, 2019

Pull Request Test Coverage Report for Build 835

  • 5 of 10 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 71.143%

Changes Missing Coverage Covered Lines Changed/Added Lines %
handlers/batch-email-sender/src/main/scala/com/gu/batchemailsender/api/batchemail/model/EmailToSend.scala 4 9 44.44%
Totals Coverage Status
Change from base Build 825: -0.09%
Covered Lines: 1960
Relevant Lines: 2755

💛 - Coveralls

Copy link
Contributor

@twrichards twrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mariogalic mariogalic merged commit 692eb4f into master Jan 24, 2019
@guardian guardian deleted a comment Jan 24, 2019
@mariogalic mariogalic deleted the add-direct-debit-mandate-failure-emails branch March 21, 2019 13:48
@frj
Copy link
Contributor

frj commented Nov 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants