Read holiday stop requests from Salesforce #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-chappell
requested review from
arausuy,
mariogalic,
twrichards and
paulbrown1982
mariogalic
reviewed
May 31, 2019
...s/holiday-stop-processor/src/main/scala/com/gu/holidaystopprocessor/HolidayStopProcess.scala
Outdated
Show resolved
Hide resolved
mariogalic
reviewed
May 31, 2019
handlers/holiday-stop-processor/src/main/scala/com/gu/holidaystopprocessor/Handler.scala
Outdated
Show resolved
Hide resolved
mariogalic
reviewed
May 31, 2019
handlers/holiday-stop-processor/src/main/scala/com/gu/holidaystopprocessor/Salesforce.scala
Show resolved
Hide resolved
mariogalic
reviewed
May 31, 2019
...liday-stop-processor/src/test/scala/com/gu/holidaystopprocessor/HolidayStopProcessTest.scala
Outdated
Show resolved
Hide resolved
mariogalic
approved these changes
Jun 3, 2019
| } | ||
|
|
||
| val from = hsr.Start_Date__c.value | ||
| val to = hsr.End_Date__c.value |
There was a problem hiding this comment.
Just checking whether this is inclusive or exclusive, maybe a comment may help the next person who comes along.
There was a problem hiding this comment.
I've done some renaming now to make this clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in integrating the holiday-stop processing lambda with Salesforce. Salesforce holds a table of holiday-stop requests. This PR reads those requests and sends them to Zuora to be processed.
There will be a separate PR to write the amendment details made by Zuora back to Salesforce.