Tweak support client side alarm thresholds to reduce noise #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlieb10
reviewed
Jul 1, 2019
| Statistic: Sum | ||
| TreatMissingData: notBreaching |
There was a problem hiding this comment.
What does this key TreatMissingData mean, out of curiosity?
There was a problem hiding this comment.
It defines what to do in the case that no events of the specified type have been recorded for the evaluation period. E.g. for error alarms we generally treat missing data as good (not breaching), whereas for request count we might treat missing data as bad (breaching) because it is effectively the same as zero in these cases.
jorgeazevedo
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be just matching what we have running, where we have changed threshold handling to reduce noise.