Move holiday-stop credit calculation #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arausuy
approved these changes
Aug 28, 2019
|
|
||
| val charges = for { | ||
| plan <- ratePlans if isMatchingPlan(plan) | ||
| charge <- plan.ratePlanCharges.find(isMatchingCharge) | ||
| charge <- plan.ratePlanCharges.find(isMatchingCharge) |
There was a problem hiding this comment.
Scalariform is supposed to sort that out. I think it's skipping this file because it doesn't like trailing commas in lists. I'll fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the credit calculation to the
holiday-stopslib where it's accessible to both theholiday-stop-processorlambda for actual credits, and theholiday-stop-apilambda for estimated credits.Next step will be to integrate it into the
holiday-stop-api.