Weekend Voucher holiday stop model #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariogalic
force-pushed
the
holiday-stop-weekend-voucher-model
branch
from
e9c0737
to
664fe3c
Compare
lib/holiday-stops/src/main/scala/com/gu/holiday_stops/CurrentWeekendVoucherSubscription.scala
Outdated
Show resolved
Hide resolved
lib/holiday-stops/src/main/scala/com/gu/holiday_stops/CurrentWeekendVoucherSubscription.scala
Show resolved
Hide resolved
| subscription: Subscription, | ||
| weekendVoucherProductRatePlanId: String, | ||
| stoppedPublicationDate: StoppedPublicationDate | ||
| ): Either[ZuoraHolidayWriteError, CurrentWeekendVoucherSubscription] = { |
There was a problem hiding this comment.
This method doesn't seem to attempt to write to Zuora
There was a problem hiding this comment.
Maybe separate refactoring PR as it would have to be hanged everywhere.
| @@ -52,7 +52,9 @@ object SalesforceHolidayStopRequestsDetail extends Logging { | |||
| case class HolidayStopRequestsDetailChargePrice(value: Double) extends AnyVal | |||
| implicit val formatHolidayStopRequestsDetailChargePrice = Jsonx.formatInline[HolidayStopRequestsDetailChargePrice] | |||
|
|
|||
| case class StoppedPublicationDate(value: LocalDate) extends AnyVal | |||
| case class StoppedPublicationDate(value: LocalDate) extends AnyVal { | |||
| def getDayOfWeek: String = value.getDayOfWeek.toString.toLowerCase.capitalize | |||
There was a problem hiding this comment.
could be val (or lazy val)
There was a problem hiding this comment.
vals are not allowed in value classes
|
👍 Looks good pending Kelvins points |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It satisfies
and is represented as
Billing periods per voucher product:
https://docs.google.com/spreadsheets/d/1gfVse_wcRPXRPeQBV3sVvJgmWKNzaBf6m0kbWKeihqY/edit?pli=1#gid=0