Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First available date contract acceptance date #448

Merged
merged 6 commits into from Oct 7, 2019
Merged

First available date contract acceptance date #448

merged 6 commits into from Oct 7, 2019

Conversation

frj
Copy link
Contributor

@frj frj commented Oct 4, 2019

This PR add some logic to the calculation of the holiday stops first available date to prevent holiday stops from being created before fulfilment has been started for that subscription:

  • Subscriptions are fetched from Zuora in calls to GET /hsr/<>
  • The GET /hsr endpoint has been removed as first available date cannot be calculated without a subscription. this endpoint is not currently in being used.
  • Subscription.customerAcceptanceDate defines when fulfilment starts.

@frj frj requested a review from a team October 4, 2019 09:30
kelvin-chappell
kelvin-chappell approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@kelvin-chappell kelvin-chappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

coveralls commented Oct 4, 2019 •
edited

Coverage Status

Coverage increased (+0.1%) to 63.307% when pulling 2ef916f on first-available-date-contract-acceptance-date into 1cbdb6b on master.

@guardian guardian deleted a comment Oct 4, 2019
@frj
removing firstAvailableDate/customerAcceptanceDate check for GWeekly
2ef916f 
This check is not necessary as the current calculation will not
let you create a holiday stop before fulfilment starts.

This check also causes problems as the customerAcceptance date is the
start of the full subscription not the start of 6-for-6 subscription
hence holiday stops would not be allowed in the 6-for-6 period.
@guardian guardian deleted a comment Oct 4, 2019
@frj frj merged commit e8b45b1 into master Oct 7, 2019
@frj frj deleted the first-available-date-contract-acceptance-date branch October 7, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvin-chappell kelvin-chappell kelvin-chappell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frj @coveralls @kelvin-chappell