Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump thrift-related dependencies #25

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Bump thrift-related dependencies #25

merged 1 commit into from
Apr 18, 2019

Conversation

regiskuckaertz
Copy link

@regiskuckaertz
Copy link
Author

Update scrooge-core and libthrift

AndyJamesMyers
AndyJamesMyers approved these changes Apr 18, 2019
View reviewed changes
Copy link

@AndyJamesMyers AndyJamesMyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regiskuckaertz regiskuckaertz merged commit 7e4dcab into master Apr 18, 2019
@regiskuckaertz regiskuckaertz deleted the rk-thrift branch April 18, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyJamesMyers AndyJamesMyers AndyJamesMyers approved these changes

@itsibitzi itsibitzi Awaiting requested review from itsibitzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@regiskuckaertz @AndyJamesMyers