Skip to content

Commit

Permalink
Merge pull request #462 from guardian/mob/remove-existing-rdsbackup-p…
Browse files Browse the repository at this point in the history
…arams

Remove existing rds backup param
  • Loading branch information
Georges-GNM committed Feb 1, 2024
2 parents 0fc0a29 + ca2e192 commit 9f1ae99
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions cdk/lib/__snapshots__/index.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1457,13 +1457,13 @@ exports[`The typerighter stack matches the snapshot 1`] = `
"AllocatedStorage": "50",
"AllowMajorVersionUpgrade": false,
"AutoMinorVersionUpgrade": true,
"BackupRetentionPeriod": 10,
"CopyTagsToSnapshot": true,
"DBInstanceClass": "db.t4g.micro",
"DBInstanceIdentifier": "typerighter-rule-manager-store-test",
"DBSubnetGroupName": {
"Ref": "DBSubnetGroup",
},
"DeleteAutomatedBackups": false,
"DeletionProtection": true,
"Engine": "postgres",
"EngineVersion": "13",
Expand All @@ -1473,7 +1473,6 @@ exports[`The typerighter stack matches the snapshot 1`] = `
},
"MultiAZ": false,
"Port": "5432",
"PreferredBackupWindow": "02:00-02:30",
"PreferredMaintenanceWindow": "Mon:06:30-Mon:07:00",
"PubliclyAccessible": false,
"StorageEncrypted": true,
Expand Down
3 changes: 1 addition & 2 deletions cdk/lib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ EOF
allocatedStorage: 50,
allowMajorVersionUpgrade: false,
autoMinorVersionUpgrade: true,
backupRetention: Duration.days(10),
deleteAutomatedBackups: false,
engine: DatabaseInstanceEngine.postgres({
version: PostgresEngineVersion.VER_13,
}),
Expand All @@ -329,7 +329,6 @@ EOF
),
multiAz: this.stage === "PROD",
port: dbPort,
preferredBackupWindow: "02:00-02:30",
preferredMaintenanceWindow: "Mon:06:30-Mon:07:00",
securityGroups: [dbAccessSecurityGroup],
storageEncrypted: true,
Expand Down

0 comments on commit 9f1ae99

Please sign in to comment.