Add pre-commit hook for Linting #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahhh inspired by your positive experiences of https://github.com/guardian/pinboard 😜 |
jonathonherbert
approved these changes
Mar 17, 2023
Co-authored-by: Jonathon Herbert <jonathon.herbert@guardian.co.uk>
Co-authored-by: Jonathon Herbert <jonathon.herbert@guardian.co.uk>
Cheers - that was my plan as I had a memory of there being a setup script, but I don't see one 🤷 |
This was referenced Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds a pre-commit hook which will auto format staged changes using ScalaFMT. It also adds a setup script whose role is sym-linking the script to the hooks dir.
How to test
Check it out, run the script, make a change and commit. The linter should run against your Scala files.
How can we measure success?
Have we considered potential risks?
Yep
Images