This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
Added InteractiveFullWidth to Design type obj #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlieb10
requested review from
sndrs and
oliverlloyd
and removed request for
sndrs
|
Based on the discussions we've had separately, can we alter this to become |
|
Thanks @jlieb10. Would it be possible to also make this change to the equivalent module in |
jlieb10
changed the title
@SiAdcock Thanks Simon - does it matter which order the merge takes place in? |
JamieB-gu
reviewed
Aug 25, 2021
nicl
approved these changes
Aug 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We are creating a new DCR template for full-width interactives, essentially combining the 'immersive' style header with the 'interactives' style body. This PR is updating the type so it can be used in DCR and on Composer.
How to test
There are no live articles of this type created yet.
How can we measure success?
Success would look like using this template and keeping TypeScript happy in DCR.
Have we considered potential risks?
This is easily revertible if it causes any unforeseen problems
Images
NA
Accessibility
NA