New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test updates and bump to android-23 #40
Conversation
By eyeball, this seems fine. Note that raising the |
Hmm, I think using netcipher only affects INTERNET permissions. Would compiling with android-23 mean changes if this lib only needs INTERNET perms? I thought that was automatic anyway. |
Nope, that's fine.
Insofar as the user isn't prompted about it from the Play Store, yes. You still need |
hmm, ok, I'm going to skip 23 now, since it also required |
Checking for a running daemon is pretty fragile, the STATUS Intent is the regular Android way of communicating, and Orbot knows its status.
You weren't using the built-in HttpClient, I thought. I thought you were using |
This should hopefully get the tests running successfully in the travis-ci builds. I also purged the old, unmaintained TLS Presense tests. I think we can do all that those tests did in JUnit style tests using services like https://badssl.com
@commonsguy