Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test updates and bump to android-23 #40

Merged
merged 9 commits into from Apr 4, 2016
Merged

Test updates and bump to android-23 #40

merged 9 commits into from Apr 4, 2016

Conversation

eighthave
Copy link
Member

This should hopefully get the tests running successfully in the travis-ci builds. I also purged the old, unmaintained TLS Presense tests. I think we can do all that those tests did in JUnit style tests using services like https://badssl.com

@commonsguy

@commonsguy
Copy link
Contributor

By eyeball, this seems fine. Note that raising the targetSdkVersion to 23 means that you have to deal with runtime permissions, though I am not sure that there are any dangerous permissions floating about.

@eighthave
Copy link
Member Author

Hmm, I think using netcipher only affects INTERNET permissions. Would compiling with android-23 mean changes if this lib only needs INTERNET perms? I thought that was automatic anyway.

@commonsguy
Copy link
Contributor

Would compiling with android-23 mean changes if this lib only needs INTERNET perms?

Nope, that's fine. *_EXTERNAL_STORAGE would be a problem, for example.

I thought that was automatic anyway.

Insofar as the user isn't prompted about it from the Play Store, yes. You still need <uses-permission> for it, though.

@eighthave
Copy link
Member Author

hmm, ok, I'm going to skip 23 now, since it also required useLibrary 'org.apache.http.legacy'

Checking for a running daemon is pretty fragile, the STATUS Intent is the
regular Android way of communicating, and Orbot knows its status.
@commonsguy
Copy link
Contributor

You weren't using the built-in HttpClient, I thought. I thought you were using ch.boye, which will exist regardless of compileSdkVersion. Perhaps my memory is fuzzy.

@eighthave eighthave merged commit 52fbe3c into guardianproject:master Apr 4, 2016
@eighthave eighthave deleted the test-updates branch April 4, 2016 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants