Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Modified execute commands to always use US for the Locale #14

Merged
merged 1 commit into from Nov 15, 2013

Conversation

micahjlucas
Copy link
Contributor

We were having issues with our generated ffmpeg commands breaking because the Locale was set to China. Our command strings were containing characters that ffmpeg couldn't interpret. So instead of checking for the locale at every ffmpeg call, we felt it would be better to handle at the source.

@vitriolix
Copy link
Member

Any chance you guys could take a look at merging this? It fixes a bug where a path isn't ever being formatted and hence the filename has a %03.jpg in it, which on 2.3.x devices is illegal and it fails. on 4.x it doesn't seem to care

@n8fr8
Copy link
Member

n8fr8 commented Nov 14, 2013

Yes

vitriolix notifications@github.com wrote:

Any chance you guys could take a look at merging this? It fixes a bug
where a path isn't ever being formatted and hence the filename has a
%03.jpg in it, which on 2.3.x devices is illegal and it fails. on 4.x
it doesn't seem to care


Reply to this email directly or view it on GitHub:
#14 (comment)

@n8fr8
Copy link
Member

n8fr8 commented Nov 15, 2013

I had this same bug btw with phones set to Arabic. Command line arguments that were numeric were printing out in Arabic numbers.

@n8fr8 n8fr8 merged commit 9357d94 into guardianproject:master Nov 15, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants