Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal: SSLPeerUnverifiedException using new build settings #273

Closed
lukeswitz opened this issue Mar 25, 2018 · 3 comments · Fixed by #282
Closed

Signal: SSLPeerUnverifiedException using new build settings #273

lukeswitz opened this issue Mar 25, 2018 · 3 comments · Fixed by #282

Comments

@lukeswitz
Copy link
Collaborator

lukeswitz commented Mar 25, 2018

After merging #269 the Signal functionality broke on both devices & simulators running 5.1-8.+. Attempting to register a local signal number, this is the response :

Request verify error: javax.net.ssl.SSLPeerUnverifiedException: Hostname textsecure-service.whispersystems.org not verified:
        certificate: sha256/HM+(removed for privacy) 
 DN: CN=textsecure-service.whispersystems.org,OU=Open Whisper Systems,O=Open Whisper Systems,ST=California,C=US
        subjectAltNames: []

I haven't gone through each dependency, so any help to reproduce this is appreciated.

Thanks all,
Luke

@n8fr8
Copy link
Member

n8fr8 commented Mar 25, 2018

It may be that we need to update the code for signal-cli-android https://github.com/guardianproject/signal-cli-android to keep up with the base project signal-cli: https://github.com/AsamK/signal-cli/commits/master

@lukeswitz
Copy link
Collaborator Author

Your branch is fine, it's the same idea as getting an insecure warning with a self-signed cert on a browser; appending an argument to the address works fine as does the Signal API.

  • The Facebook & Picasso updates are not needed, requires a higher min SDK and causes the above issue. Things start to get weird but don't break using 1.8.0 & 2.5.2:
org.havenapp.main V/StudioProfiler: Transformed class: okhttp3/OkHttpClient
org.havenapp.main W/org.havenapp.main: Current dex file has more than one class in it. 
Calling RetransformClasses on this class might fail if no transformations are applied to it!
org.havenapp.main W/System.err: Request verify error: Bad response: 400 Bad Request

Proposing PR to fix this issue.

@lukeswitz
Copy link
Collaborator Author

Reopened for review of PR

@lukeswitz lukeswitz reopened this Apr 2, 2018
@n8fr8 n8fr8 closed this as completed in #282 Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants