Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignalSender Context leak #399

Open
archie94 opened this issue Apr 26, 2019 · 0 comments
Open

SignalSender Context leak #399

archie94 opened this issue Apr 26, 2019 · 0 comments

Comments

@archie94
Copy link
Collaborator

SignalSender being a singleton keeps reference to the context.
archie94 added a commit to archie94/haven that referenced this issue Apr 26, 2019
@archie94
Keep application context in Signal Sender
99eded9 
- keeping Context (Activity/Fragment) in a singleton will cause memory leaks
  Keep the global application object associated with it instead
- fix guardianproject#399

Signed-off-by: Arka Prava Basu <arkaprava94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@archie94