Don't show password on screen #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be handled several ways to optimize, but I just kept it looking like the current way the settings are done, including a separate file for the dialog. Note: those ?dialogPreferredPaddings are coming up red in AS, but I guess it doesn't break anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EditTextPreference's inputType="textPassword" in
settings.xmlis currently ignored because its dialog layout uses a regular "text" inputType. So I fixed it.This could be handled several ways for size, but I just kept it matching the current way the settings are done, including a separate file for the dialog layout.
Note: those ?dialogPreferredPaddings are coming up red in AS and probably shouldn't be used like that, but I guess it doesn't break anything. I just used the same file basically as src/main/res/layout/pref_dialog_edit_text.xml only for a password field.
Also changed it so that the password isn't displayed on the setting, but rather a fixed-# of bullets.
Question, and I'll probably make this an official issue, but should the password and/or other fields be available to Oreo's Autofill service? If not, we might want to explicitly deny it, but I didn't do it in this commit.