Skip to content

Commit

Permalink
Merge pull request #141 from bitmold/no-phone-state-perm
Browse files Browse the repository at this point in the history
removed legacy READ_PHONE_STATE perm
  • Loading branch information
n8fr8 committed Apr 20, 2018
2 parents d0cc453 + 505223b commit d1daf86
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion app/src/fullperm/AndroidManifest.xml
Expand Up @@ -14,7 +14,6 @@
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS" />
<uses-permission android:name="android.permission.READ_PHONE_STATE" />
<!-- Some Chromebooks don't support touch. Although not essential,
it's a good idea to explicitly include this declaration. -->
<uses-feature android:name="android.hardware.touchscreen"
Expand Down
5 changes: 0 additions & 5 deletions docs/WALKTHROUGH
Expand Up @@ -20,11 +20,6 @@
//this is the class registered in AndroidManifest.xml to handle Onboot events
//to start Orbot/Tor when the device boots if the user has elected to do so - what kind of permissions does this require?
// <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED"/>
// BTW, this shows up as a fairly unintrusive type perm request now in Android / in older versions (1.6 and earlier)
// it was reported "as read / monitor phone state" and paranoid Tor-types didn't like the idea of it
// in 1.6+ it has a much better UX in terms of having a more granular permisions around boot since it is a very
// common request - ah , that's awesome, i think i remember seeing sth of this sorts when i was going through the guardianproject mailing list. iirc this is something ioerror wanted


├── OrbotMainActivity.java
//our wonderful main activity!
Expand Down

0 comments on commit d1daf86

Please sign in to comment.