Rewrite OnionServiceDeleteDialogFragment in Kotlin #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but wondering if you have you used this code to delete an onion service and have seen the functionality to be the same? |
Yes, I have tested it using the emulator and it seems to work fine. Screen_recording_20240502_203235.mp4 |
|
Cool thanks! If you're up for it, it'd be cool to have this screen use an empty view for when there are no user/app services being listed.. |
|
Thanks for the feedback, you mean a placeholder text/image like this, right? I was already planning to improve the UI by replacing the radio buttons with segmented buttons and this can be a nice addition to that. |
|
Yup, that's what I meant ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the Kotlin rewrite with the Onion Service.
Tested on Pixel 8 API 34.