Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings UI Improvements #135

Merged
merged 5 commits into from Apr 20, 2018
Merged

Settings UI Improvements #135

merged 5 commits into from Apr 20, 2018

Conversation

bitmold
Copy link
Collaborator

@bitmold bitmold commented Mar 28, 2018

  • all preferences for setting a port use inputType="number" on their EditTextPreference now.
  • the proxy password EditTextPreference uses inputType="password" to give it dingbats
  • minor ui string updates on this screen:
    • socks4/5 --> SOCKS4/5
    • all preference summaries have similar capitalization
    • aLocCat --> aLogcat

One thing I would have liked to change but did not is the EditTextPreference for proxy type. The user is supposed to enter one of {HTTP, HTTPS, SOCKS4, SOCKS5} but they can enter anything. It would make sense here to use a ListPreference instead of an EditTextPreference, however I did not make the change to one because user preference data could be lost when users update the app.

For example, if the entriesValue set for the ListPreference is {"http", "https", "socks4", "socks5"} and a user had previously configured the preference "pref_proxy_type" with the EditTextPreference to "HTTP" (instead of "http"), the ListPreference would be set to no value. It's particularly unfortunate, because we don't even care about the casing of the proxy type.

@n8fr8 n8fr8 merged commit e0293ac into guardianproject:master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants