Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inputType="number"
on theirEditTextPreference
now.EditTextPreference
usesinputType="password"
to give it dingbatsOne thing I would have liked to change but did not is the
EditTextPreference
for proxy type. The user is supposed to enter one of {HTTP, HTTPS, SOCKS4, SOCKS5} but they can enter anything. It would make sense here to use aListPreference
instead of anEditTextPreference
, however I did not make the change to one because user preference data could be lost when users update the app.For example, if the
entriesValue
set for theListPreference
is {"http", "https", "socks4", "socks5"} and a user had previously configured the preference"pref_proxy_type"
with theEditTextPreference
to "HTTP" (instead of "http"), theListPreference
would be set to no value. It's particularly unfortunate, because we don't even care about the casing of the proxy type.