Fixes #300 Where Locale is set to Zulu when settings are opened #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, I really hope this is finally the solution to this hilarious bug. THANK YOU! |
|
I'm confident it is :+) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locale to the app was set to isiZulu (
zu) when the Settings screen is opened even if the user didn't explicitly set another language. This is because of a line inLanguages.javain a loop for each Locale:config.locale = localeis assigned to the Activity's Configuration object.This assignment is not necessary and occurs for each Locale supported by the app. The reason the locale is always set to isiZulu because
zuis the last locale alphabetically included in Orbot.Bug #300 says that only context menu text is changed to isiZulu because Orbot doesn't have any isiZulu localization, so only the Android context menu changes. If more isiZulu localization was included in Orbot, other parts of the app would have been effected too. This bug is for every language supported in Orbot, any time you open the settings and do not explicitly set a locale.
This PR removes the assignment statement causing the bug, and also removes some code that isn't used by the app anymore.