Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete rs-rAR translation #341

Merged
merged 2 commits into from May 30, 2020
Merged

Delete rs-rAR translation #341

merged 2 commits into from May 30, 2020

Conversation

nijel
Copy link
Contributor

@nijel nijel commented May 18, 2020

  • I don't think there is Serbian used in Argentina.
  • The few existing strings seem to be actually Spanish, so it was probably meant to be es-rAR.

- I don't think there is Serbian used in Argentina. 
- The few existing strings seem to be actually Spanish, so it was probably meant to be es-rAR.
@bitmold
Copy link
Collaborator

bitmold commented May 19, 2020

This is a nice catch! I also don't think it's needed but I'm not 100% certain.

If this isn't needed though there's still a values-rs-rAR/strings.xml in the app project that needs to be deleted too.

- I don't think there is Serbian used in Argentina. 
- The few existing strings seem to be actually Spanish, so it was probably meant to be es-rAR.
@nijel
Copy link
Contributor Author

nijel commented May 19, 2020

I've added the second file as well.

@n8fr8 n8fr8 merged commit 44ece31 into guardianproject:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants