First stab at modularizing shared code between app projects #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bitmold
commented
Sep 10, 2020
•
bitmold
commented
- created an "appcore" module where shared code between the two app and proposed app mini projects can exist
|
Looks, builds and works for me. I like breaking out these small bits to do migration to Kotlin as well. Should I merge this, or do you want to do more work here? |
n8fr8
approved these changes
Sep 11, 2020
|
Ya i think it can be merged. As the requirements for orbot mini get a it more established there might be more/less that needs to be modularized than what is here right now, time will tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.