Fixes #180, #392 Migration of Backup Features to Android Storage Access Framework (SAF) #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitmold
added a commit
that referenced
this pull request
Sep 24, 2020
(this sets us up to fully remove the permission on APIs 19+ after #395 is merged
bitmold
added a commit
that referenced
this pull request
Sep 24, 2020
(this sets us up to fully remove the permission on APIs 19+ after #395 is merged
service backup/restore. Deleted many resources that are no longer needed
Cookie backup/restore works. Cleaned up many more old resources, styled dialogs to match Android conventions.
- UI is ready for v3 client cookies (just uncomment one line of code) - when text input is incorrect, the submit button will be disabled rather dismissing the dialog and showing the user a vague Toast + erasing all their input
|
I just tested backup and restore for client cookies and hosted services on API 16 and 30 and the functionality was expected!! I shouldn't be pushing anymore code here unless you find something messed up in your review or testing @n8fr8 Here is the new cookie backup/restore flow: Here is the new hosted service backup/restore flow: The new cookie dialog and new hosted service dialogs: |
|
building and working well here. code looks good. will review a bit more, and merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot happening in this pull request...
WRITE_EXTERNAL_STORAGEon APIs 16, 17, and 18.WRITE_EXTERNAL_STORAGEpermission. Dialogs pertaining to selecting a backup were deleted from the project since a system dialog gets the job done.GIFs and a more thorough breakdown of things to come...