Guards Against Context Memory Leaking #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitmold
changed the title
…WizardActivity + AppManagerActivity. Removes huge warnings from code. Anonymous AsyncTask implementations (such as Handler) implicitly hold a reference to the outer Activity, this could cause a memory leak where the AsyncTask is still running after the Activity has terminated
n8fr8
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used static inner classes for
AsyncTasksinOrbotMainActivity,BridgeWizardActivityandAppManagerActivity. Removes massive warnings from code. Basically anonymous AsyncTask implementations (such as Handler) implicitly hold a reference to the outerActivity, this could cause a memory leak where the AsyncTask is still running after the Activity has terminated preventing the latter from being properly garbage collected.https://www.androiddesignpatterns.com/2013/01/inner-class-handler-memory-leak.html