Fixes #401 Only NEWNYM Through UI When Sensible #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bitmold
commented
Oct 16, 2020
bitmold
commented
- The "NEW IDENTITY" button in the notification is only visible when the user can click on it
- Clicking the refresh button in the main app gives you a new identity if you have one, does nothing if Tor is starting, and starts tor if it's off/stopping
- The "NEW IDENTITY" button in the notification is only visible when the user can click on it - Clicking the refresh button in the main app gives you a new identity if you have one, does nothing if Tor is starting, and starts tor if it's off/stopping
bitmold
commented
Oct 16, 2020
| @@ -223,64 +225,45 @@ private void createNotificationChannel() { | |||
| mNotificationManager.createNotificationChannel(mChannel); | |||
| } | |||
|
|
|||
| @SuppressLint("NewApi") | |||
| @SuppressLint({"NewApi", "RestrictedApi"}) | |||
There was a problem hiding this comment.
This RestrictedApi thing is the call to mNotifyBuilder.mActions.clear() which IMO is fine to do. Normally you wouldn't need to clear actions because you wouldn't hang on to a notify builder object like we do here, but anyway ya I think it's fine tbh.
n8fr8
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.