Fix CI/CD pipeline

[hax0rbana-adam]

It looks like there are linter errors that are stopping the CI/CD from running on all branches, so I thought I'd take a shot at trying to fix them.

This builds on !965 since that's the MR where I was trying to make the CI/CD green. I didn't commit it over there because I didn't want to force these changes to be accepted with the logo change.

[hax0rbana-adam]

I guess not, Bitrise is still failing nearly instantly. I think the issue is in the Bitrise workflow configuration. I had to change mine to get it to get past the new Java 17 requirement, like so:

1. In Bitrise, go to a pipeline that is failing (example)
2. If you're logged in, you should see an Edit workflow button. Click that.
3. On the left, click on the Plus button above Git Clone Repository
4. Search for Java, and click Set Java Version
5. Change Java version (under Input variables) to 17

The changes in this branch are also required, but the errors that are being fixed won't appear until the pipeline can get past the current error ("error: invalid source release: 17").

[n8fr8]

THanks, we'll work on getting bitrise fixed up again.

[meenbeese]

I will also try to help this get resolved faster. Can you rebase on master so everything is up-to-date @hax0rbana-adam ? I want to take a look on what the actual problem is that the applied changes cannot fix.

[hax0rbana-adam]

I have rebased on the default branch, and I think I even did so correctly this time.

[meenbeese]

Thanks! It looks like there is a mismatch in the Java version we use.

> Task :intentintegrator:compileDebugJavaWithJavac FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':intentintegrator:compileDebugJavaWithJavac'.
> error: invalid source release: 17

Plus, things are broken starting from #903, as Bitrise checks passed before. Could you try to revert said PR and see if my hypothesis is true or not?

[syphyr]

No need to revert, just change here to 17.

orbot/.github/workflows/android.yml

Line 22 in 5457cf1

java-version: 1.8

[hax0rbana-adam]

I updated the java version in .github/workflows/android.yml, but I still think the change need to be made in the bitrise UI.

[n8fr8]

Will review this week

[n8fr8]

fixed now... had to add the bitrise step to set java sdk to 17