Changes to compile tor 0.3.5.3-alpha #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic! No reason not to support alpha builds, since we need to be able to test some of the improvements in memory use and other mobile optimizations coming in newer releases. Will test this out in the coming days. |
goapunk
reviewed
Nov 2, 2018
| @@ -253,6 +253,7 @@ tor/configure: | |||
|
|
|||
| tor/Makefile: tor/configure | |||
| cp config.sub tor | |||
| sed -i '14i #include <errno.h>' tor/src/lib/fs/freespace.c | |||
There was a problem hiding this comment.
Since this is merely a workaround for a bug in tor we should maybe report this and remove it once it has been fixed.
There was a problem hiding this comment.
There was a problem hiding this comment.
There's a fix on its way (see the ticket) so I think we should wait for the next alpha and remove this?
|
As @n8fr8 applied the necessary changes (afaik) I think we can close this MR and the related issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #9 this is a proposal, the changes needed to make 0.3.5.3-alpha be supported
Granted support for an alpha version may not be desired at this moment, but this work should carry forward and be relevant to when 0.3.5.* stabilizes so I'm PRing this now so it can go quickly at your discretion.
Thanks!