Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monkey - Don't crash when receiving unknown configuration variables #26

Closed
danielguardicore opened this issue Aug 22, 2016 · 2 comments
Closed

Monkey - Don't crash when receiving unknown configuration variables #26

danielguardicore opened this issue Aug 22, 2016 · 2 comments

Comments

@danielguardicore
Copy link
Contributor

danielguardicore commented Aug 22, 2016 •
edited

Instead of crashing if the monkey deserializes an unknown configuration variable, send an error message to the current monkey server and keep on working.
@Fak3
Copy link
Contributor

Fak3 commented Sep 24, 2016

What a server should do on receipt of such error message? Store the fact in the monkey json?

What is the desired api for this mesage delivery? Can it be done via PATCH request to /api/monkey/{guid} with data {'config_error': True}.

@Fak3 Fak3 mentioned this issue Sep 26, 2016
Closed
@danielguardicore
Copy link
Contributor Author

  1. Yes. We currently don't differentiate different messages in the log window but can maybe highlight errors.

  2. Yes.

Fak3 added a commit to Fak3/monkey that referenced this issue Sep 27, 2016
@Fak3
Don't crash when receiving unknown configuration variables
bfea4fa 
Instead of crashing if the monkey deserializes an unknown configuration
variable, send an error message to the current monkey server and keep on
working.

fixes guardicore#26
@Fak3 Fak3 mentioned this issue Sep 27, 2016
Merged
Fak3 added a commit to Fak3/monkey that referenced this issue Sep 27, 2016
@Fak3
Don't crash when receiving unknown configuration variables
f1dca7f 
Instead of crashing if the monkey deserializes an unknown configuration
variable, send an error message to the current monkey server and keep on
working.

Add utnittests.

fixes guardicore#26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fak3 @danielguardicore