Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to rjsf component #2694

Closed
5 of 8 tasks
VakarisZ opened this issue Dec 14, 2022 · 0 comments · Fixed by #2732
Closed
5 of 8 tasks

Migrate to rjsf component #2694

VakarisZ opened this issue Dec 14, 2022 · 0 comments · Fixed by #2732
Labels
Feature Issue that describes a new feature to be implemented.
Projects
Monkey Dev Board

Comments

@VakarisZ
Copy link
Contributor

VakarisZ commented Dec 14, 2022 •
edited by mssalvatore

Is your feature request related to a problem? Please describe.

We need to migrate because of multiple reasons. Main reasons are easier styling and bugs like rjsf-team/react-jsonschema-form#3287
It also has better styling, allows us to migrate front end framework easily

More context in #2661

Tasks
@VakarisZ VakarisZ added the Feature Issue that describes a new feature to be implemented. label Dec 14, 2022
@mssalvatore mssalvatore added this to In progress in Monkey Dev Board Dec 14, 2022
@VakarisZ VakarisZ mentioned this issue Dec 14, 2022
Closed
14 tasks
@cakekoa cakekoa mentioned this issue Dec 14, 2022
Merged
8 tasks
@VakarisZ VakarisZ mentioned this issue Dec 15, 2022
Merged
8 tasks
cakekoa added a commit that referenced this issue Dec 15, 2022
@cakekoa
UI: Hide the configuration page error summary
ecc3df4 
Issue: #2694
PR: #????

This was already being hidden, but the theme was updated when upgrading,
prompting this change.
@cakekoa cakekoa mentioned this issue Dec 15, 2022
Merged
8 tasks
cakekoa added a commit that referenced this issue Dec 15, 2022
@cakekoa
UI: Hide the configuration page error summary
4ccd99e 
Issue: #2694
PR: #2713

This was already being hidden, but the theme was updated when upgrading,
prompting this change.
VakarisZ pushed a commit that referenced this issue Dec 15, 2022
@cakekoa @VakarisZ
UI: Hide the configuration page error summary
3f3c024 
Issue: #2694
PR: #2713

This was already being hidden, but the theme was updated when upgrading,
prompting this change.
@VakarisZ VakarisZ mentioned this issue Dec 19, 2022
Merged
8 tasks
mssalvatore added a commit that referenced this issue Dec 19, 2022
@mssalvatore
Merge branch '2694-fixup-styles' into develop
e15028b 
Issue #2694
PR #2728
@VakarisZ VakarisZ mentioned this issue Dec 19, 2022
Merged
8 tasks
VakarisZ added a commit that referenced this issue Dec 19, 2022
@VakarisZ
UI: Remove unused css in configuration page
22c7598 
Issue: #2694
PR: #2732
mssalvatore pushed a commit that referenced this issue Dec 19, 2022
@VakarisZ @mssalvatore
UI: Remove unused css in configuration page
fb8909f 
Issue: #2694
PR: #2732
Monkey Dev Board automation moved this from In progress to Done Dec 19, 2022
@VakarisZ VakarisZ mentioned this issue Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Issue that describes a new feature to be implemented.
Projects
Monkey Dev Board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2694 remove unused css guardicore/monkey
1 participant
@VakarisZ