Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin selector with options #2698

Closed
5 tasks done
VakarisZ opened this issue Dec 14, 2022 · 0 comments · Fixed by #2852
Closed
5 tasks done

Plugin selector with options #2698

VakarisZ opened this issue Dec 14, 2022 · 0 comments · Fixed by #2852
Labels
Complexity: High Feature Issue that describes a new feature to be implemented. Plugins

Comments

@VakarisZ
Copy link
Contributor

VakarisZ commented Dec 14, 2022

Is your feature request related to a problem? Please describe.
The plugins we're adding support options. We need to be able to show the options specified in the plugin configuration schema.

Describe the solution you'd like
Please describe the desired behavior.

More context in #2661

Tasks

  • Create a basic template and UI schema that would link vulnerability exploiter schema with that template (0d) - @VakarisZ
  • Modify the prototype selector UI, to have checkmarks indicating the selection of the plugin. Take a look at prototype template and prototype selector component. Instead of dropdown selector it should be something like in advanced selector (maybe we can reuse it?). Don't overkill the styling, there's Improve the plugin selection style #2700 for that. (0d) - @VakarisZ
    • Remove the plugins from an instance if they are not enabled. Once this is fixed we'll be able to remove this. Overall data transformation is not a bad solution in this case, because we need to generate a default plugin instance either way. Removing objects we don't need might even be easier than explicitly generating the objects we need.
  • Add a safety check and a warning for unsafe options (0d) @VakarisZ
  • Fix safe options reset button (0d) @ilija-lazoroski
@VakarisZ VakarisZ added Feature Issue that describes a new feature to be implemented. Complexity: High Plugins labels Dec 14, 2022
@VakarisZ VakarisZ mentioned this issue Dec 14, 2022
14 tasks
@mssalvatore mssalvatore added this to Backlog in Monkey Dev Board Dec 14, 2022
@mssalvatore mssalvatore moved this from Backlog to To Do in Monkey Dev Board Jan 11, 2023
@VakarisZ VakarisZ moved this from To Do to In Progress in Monkey Dev Board Jan 11, 2023
@VakarisZ VakarisZ moved this from In Progress to To Do in Monkey Dev Board Jan 17, 2023
@mssalvatore mssalvatore moved this from To Do to In Progress in Monkey Dev Board Jan 17, 2023
@ilija-lazoroski ilija-lazoroski moved this from In Progress to Ready For Review in Monkey Dev Board Jan 18, 2023
Monkey Dev Board automation moved this from Ready For Review to Done Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: High Feature Issue that describes a new feature to be implemented. Plugins
Projects
Development

Successfully merging a pull request may close this issue.

1 participant