Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing configuration values in server.json lead to crash when exporting findings to security hub #430

Closed
danielguardicore opened this issue Sep 4, 2019 · 0 comments · Fixed by #432
Closed

Missing configuration values in server.json lead to crash when exporting findings to security hub #430

danielguardicore opened this issue Sep 4, 2019 · 0 comments · Fixed by #432
Assignees
@danielguardicore @ShayNehmad
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island.

Comments

@danielguardicore
Copy link
Contributor

danielguardicore commented Sep 4, 2019 •
edited
Loading

Describe the bug
When the Island is installed on an AWS machine but is not configured for AWS mode then it crashes when exporting findings due to missing values.

configured_product_arn = load_server_configuration_from_file()['aws'].get('sec_hub_product_arn', '')
KeyError: 'aws'

To Reproduce
Steps to reproduce the behavior:

  1. Install a generic Monkey Island on an AWS machine
  2. Generate some report
  3. See crash

Expected behavior
If not configured as AWS machine, do not export to AWS security hub

Machine version(please complete the following information):

  • OS: Windows or Linux
@danielguardicore danielguardicore added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. AWS labels Sep 4, 2019
@danielguardicore danielguardicore mentioned this issue Sep 5, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielguardicore danielguardicore

@ShayNehmad ShayNehmad

Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/aws export with no config guardicore/monkey
2 participants
@danielguardicore @ShayNehmad