Feature/report exporters #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added exporters and aws exporter * changed report generation to be automatic on monkey death with support of on-demand report generation and mongo storage
* Added boto session creation using credentials * Added a flag in the get_config function to separate island configuration values from monkey ones. *
* changed findings resource to ec2 instance id instead of IP
* Moved productARN to server_config.json file
* Added exporters and aws exporter * changed report generation to be automatic on monkey death with support of on-demand report generation and mongo storage
* Added boto session creation using credentials * Added a flag in the get_config function to separate island configuration values from monkey ones.
* changed findings resource to ec2 instance id instead of IP
* Moved productARN to server_config.json file
* Added aws region getter
…eature/report_exporters
* Added aws region getter
* switched to using the aws account id from the island's configuration page
…monkey's needs * Removed space char from the default value of the aws keys * Changed the submit function in the JS to point to the right endpoint
* Changed the productARN to the monkey's ARN
* Added a safe dict key access for aws_instance_id in report.py * Added a skip in the aws_export if there is no instance_id in the issue.
* building the product ARN dynamically * Resource type is now Other in case we dont have instance_id
* added error handling in report.py
* Added further inspection in telemtry
* Added some safe checks for formatting and happy flows * Removed productARN from server_config.json - it will now be inserted in deb build. * Added the awscli lib to be installed via pip
itaymmguardicore
suggested changes
Dec 2, 2018
…eton is created and populated with the relevant exporters (the aws exporter in this case) - changed the report file to use the new exporter manager singleton - changed the finding structure in the aws_exporter.py, divided it to creation functions and cleaned the code.
# Conflicts: # monkey/common/cloud/aws.py # monkey/monkey_island/cc/services/config.py
- some pep8 - Added a report json cleanup for mongo insertion, sometimes machine names are used as keys and these names might contain '.' which mongodb doesn't allow. - Fixed a typo and aws sec hub protocol requirements
…r '.' in keys names and sometimes machine names might include '.' char in them. We encode with ',,,' and decode back to '.'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature / Fixes
This feature integrates the monkey's report findings with the new AWS security hub service.
Changes