Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for password authentication with island #260

Merged
merged 1 commit into from Feb 7, 2019

Conversation

itaymmguardicore
Copy link
Contributor

@itaymmguardicore itaymmguardicore commented Feb 6, 2019

Feature / Fixes

Add option to authenticate with island using password

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you successfully tested your changes locally?

Changes

Replace PyCrypto with Cryptodome
@danielguardicore
Copy link
Contributor

Looks good to me, except we should probably note somewhere that since we only hash our password with SHA3 and not something like scrpyt/bcrypt, that we're not saying you can't brute force our page.

Either way, LGTM. It can go in. Can you add a quick Wiki page on how to set up an Island with password protection?

@itaymmguardicore itaymmguardicore merged commit 6c17767 into develop Feb 7, 2019
@itaymmguardicore itaymmguardicore deleted the feature/add-island-password-auth branch February 7, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants