Abstract companion objects #158
Conversation
|
@kelnos As we're still dual-shipping 2.11 and 2.12, we can't use trailing commas |
Since Java doesn't have the concept of a companion object, we can't use the `companion` member of a few of the term case classes properly. The closest thing Java has is static members on a regular class, so we'll represent the companion as just a list of imports, declarations, object members, and values, and wrap them in an object when building Scala class files.
kelnos
force-pushed
the
abstract-companion-objects
branch
from
92fb546
to
248603f
Compare
|
@blast-hardcheese ah damn, forgot. fixed, tests are passing again. |
| @@ -8,6 +8,12 @@ import com.twilio.guardrail.languages.LA | |||
| import com.twilio.guardrail.terms.{ ScalaTerms, SwaggerTerms } | |||
| import com.twilio.guardrail.protocol.terms.protocol.ProtocolSupportTerms | |||
|
|
|||
| case class StaticDefns[L <: LA](className: String, | |||
There was a problem hiding this comment.
I think this may end up being cumbersome in Java, as you'll need to check to make sure the static members are being added to the same class; at some point in the future, we may need cats.data.Ior[Defn.Class, StaticDefinitions[L]] to keep them associated. I think most of the time when we're emitting classes, there's only one in scope, so this isn't a problem at the moment.
There was a problem hiding this comment.
Yeah, I'm not 100% happy with this, but at the same time I do like the fact that these things are separated. If we mash class+object generation together, then it becomes annoying for Scala. Maybe that's ok? I dunno; I'm feeling ok with this incremental change now... what do you think?
There was a problem hiding this comment.
Oh, you already hit the approve button, so I guess you're ok with it too ;)
Companion objects are a feature somewhat unique to Scala, so we need to abstract them out. The per-language generators can do what they need to do from there. For example, the Java generator will turn them into
staticdeclarations on the associated class (if any).