Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Tracker history for fallback errors #1593

Merged
merged 1 commit into from Sep 25, 2022

Conversation

blast-hardcheese
Copy link
Member

Fixes #1592

Oversight when using unwrapTracker on the fallback projection. unwrapTracker falsely gave the impression that all was handled, unapply would have clearly communicated that we need to do something with the history string.

@blast-hardcheese blast-hardcheese added the bug Unexpected behaviour for functionality that either was intended to work, or has worked in the past label Sep 25, 2022
@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Base: 84.69% // Head: 83.16% // Decreases project coverage by -1.53% ⚠️

Coverage data is based on head (50637e2) compared to base (d2917e2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1593      +/-   ##
==========================================
- Coverage   84.69%   83.16%   -1.54%     
==========================================
  Files          99       99              
  Lines        5749     5749              
  Branches      163      163              
==========================================
- Hits         4869     4781      -88     
- Misses        880      968      +88     
Impacted Files Coverage Δ
...ore/src/main/scala/dev/guardrail/SwaggerUtil.scala 77.48% <0.00%> (-12.05%) ⬇️
...dev/guardrail/generators/spi/FrameworkLoader.scala 80.95% <0.00%> (-14.29%) ⬇️
...a/dev/guardrail/generators/LanguageParameter.scala 89.36% <0.00%> (-10.64%) ⬇️
...a/dev/guardrail/generators/ProtocolGenerator.scala 89.70% <0.00%> (-8.98%) ⬇️
...ev/guardrail/generators/scala/ScalaGenerator.scala 84.05% <0.00%> (-6.53%) ⬇️
...ain/scala/dev/guardrail/core/extract/package.scala 93.75% <0.00%> (-6.25%) ⬇️
...la/dev/guardrail/generators/SwaggerGenerator.scala 70.54% <0.00%> (-4.66%) ⬇️
...l/generators/scala/ScalaCollectionsGenerator.scala 65.21% <0.00%> (-4.35%) ⬇️
...scala/dev/guardrail/core/extract/Extractable.scala 50.00% <0.00%> (-4.17%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blast-hardcheese blast-hardcheese merged commit 3e39e37 into guardrail-dev:master Sep 25, 2022
@blast-hardcheese blast-hardcheese deleted the bug-1592 branch September 25, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behaviour for functionality that either was intended to work, or has worked in the past
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing type mapping for class io.swagger.v3.oas.models.media.Schema
1 participant