Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error message for HTTP status codes #436

Merged
merged 1 commit into from
Nov 7, 2019
Merged

improve error message for HTTP status codes #436

merged 1 commit into from
Nov 7, 2019

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Nov 7, 2019 •
edited

"Unknown HTTP type" --> "Unknown HTTP status code"

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@sullis
improve error message for HTTP status codes
79cc641 
"Unknown HTTP type" --> "Unknown HTTP status code"
blast-hardcheese
blast-hardcheese approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@blast-hardcheese blast-hardcheese merged commit 04dd2d4 into guardrail-dev:master Nov 7, 2019
@sullis sullis deleted the improve-status-code-error-message branch November 7, 2019 16:49
@blast-hardcheese blast-hardcheese added this to the v0.54.3 milestone Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blast-hardcheese blast-hardcheese blast-hardcheese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.54.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sullis @blast-hardcheese