Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Notebook Runs #793

Merged
merged 15 commits into from
May 28, 2024
Merged

Conversation

CalebCourier
Copy link
Collaborator

Notebooks aren't passing, but they're actually running and failing when they should now.

Summary of changes:

  • Use pip instead of poetry to mimic end user
  • Install the local branch using pip pip install .
  • Remove local guardrails directory so python knows to use the installed module
  • Fix duplicate name in other notebook

@CalebCourier CalebCourier merged commit 1958211 into hub-playground-integration-fixes May 28, 2024
3 of 24 checks passed
@CalebCourier CalebCourier deleted the fix-notebooks branch May 28, 2024 22:21
CalebCourier added a commit that referenced this pull request May 30, 2024
* remove unnecessary warning

* escape validator names in on-fail attributes

* lint fixes

* fix stubbed document stores

* add required_model_auth prop to manifest class

* add display name to model auth

* enable passing serializeable metadata to api

* lint fixes

* enable server support for litellm

* fix litellm checks

* update guardrails api client

* pass prompt, instr, msg history as kwargs to api

* api streaming support

* autoformat

* lint fix

* type fixes

* refactor guard save, enable guard.use syntax for api

* autoformat

* error handling

* remove hardcoded name

* poetry lock

* lint fix

* type fix

* Fix Notebook Runs (#793)

* Try to fix hub installs for notebooks

* remove poetry references

* install huggingface cli

* reduce to one notebook for debugging

* use bin processs

* install nltk

* show nltk

* which pip

* alter path, debug

* which python

* source in every step

* don't use poetry in script

* run all notebooks

* exit 1 on notebook failure

* remove double bar

* fix precommit

* loosen otel requirements

* use semver in checks

* fix bad merge

* fix excludes

* type ignore for python 3.8
@zsimjee zsimjee added this to the v0.4.5 release milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants