Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a brew package for mac-cli #28

Closed
dbkaplun opened this issue Jun 27, 2016 · 17 comments
Closed

Make a brew package for mac-cli #28

dbkaplun opened this issue Jun 27, 2016 · 17 comments

Comments

@dbkaplun
Copy link

Please. :)

@guarinogabriel
Copy link
Owner

@dbkaplun Absolutely! That is a great idea and it will implemented soon.

@sheerun
Copy link

sheerun commented Jun 28, 2016

I refuse to install it without homebrew ;)

@romeroabelleira
Copy link

romeroabelleira commented Jun 30, 2016

First thing would be to tag a version, so that a hombrew formula can be written against it.
I'm willing to write one*, provided you tag a version.

*or just help, if that's something you'd rather do yourself. Your call :)

@guarinogabriel
Copy link
Owner

@romeroabelleira Sure. You can move forward with that and write one, your contribution is very much appreciated! I will mark this as "in progress" then. Thanks!

@romeroabelleira
Copy link

romeroabelleira commented Jun 30, 2016

Great 😀
$ git tag v0.1 then $ git push origin --tags and I'll get going.

Edit: Listen to sheerun 👇

@sheerun
Copy link

sheerun commented Jun 30, 2016

Please use semver and git tag v0.0.1 or even better git tag v1.0.0 :)

@guarinogabriel
Copy link
Owner

guarinogabriel commented Jul 3, 2016

Hi @romeroabelleira,

I pushed the following tag:
* [new tag] v1.0.0 -> v1.0.0

Please take into account that the installation process has been improved.
You can find the installation script here:
/mac-cli/tools/install

The installation is done run by running any of the following commands now:
curl

sh -c "$(curl -fsSL https://raw.githubusercontent.com/guarinogabriel/mac-cli/master/mac-cli/tools/install)"

or wget

sh -c "$(wget https://raw.githubusercontent.com/guarinogabriel/mac-cli/master/mac-cli/tools/install -O -)"

Thanks for your contribution!

@guarinogabriel
Copy link
Owner

guarinogabriel commented Jul 4, 2016

@romeroabelleira Please let me know if the PR is in progress. Thanks!

@romeroabelleira
Copy link

I’ll start this evening (~ 19:00 CEST). I’ll keep you posted. 👍

On 05 Jul 2016, at 01:47, Gabriel Guarino notifications@github.com wrote:

@romeroabelleira https://github.com/romeroabelleira Please let me know if the PR is in progress. Thanks! :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #28 (comment), or mute the thread https://github.com/notifications/unsubscribe/AAGoEuFLLwa9KaT17Khna2caogjO92qZks5qSZuAgaJpZM4I_WoA.

@guarinogabriel
Copy link
Owner

guarinogabriel commented Jul 5, 2016

@romeroabelleira Thanks! 👍

@z11h
Copy link
Contributor

z11h commented Jul 6, 2016

Any update on this?

Thanks! 😃😃😃

@romeroabelleira
Copy link

romeroabelleira commented Jul 7, 2016

I dropped the ball there. It's been a hectic couple of days. Anyway, here's how far I got:
I can't use mac-cli/tools/install because it throws an error. Understandable, since it tries to clone the repo and then configure the tool. I'm under the impression that it's bad form to ask for user input during brew install (is this accurate?), so an info text with an instruction to run an offline-install script would probably be good enough.

Unless somebody disagrees, the next step would be to write mac-cli/tools/offline-install.

Context:

class MacCli < Formula
  desc " OS X command line tools for developers – The ultimate tool to manage your Mac. It provides a huge set of command line commands that automatize the usage of your OS X system."
  homepage "https://github.com/guarinogabriel/Mac-CLI"
  url "https://github.com/guarinogabriel/Mac-CLI/archive/v1.0.0.tar.gz"
  version "1.0.0"
  sha256 "a6bcc9fd99f1c2c927257922aca72c0239a423bf4adc5e2bc06ecc10690a8f82"

  def install
    system "mac-cli/tools/install"
  end

  test do
    system "mac", "help"
  end
end

@romeroabelleira
Copy link

Confirmed:

We don’t allow interactivity during install in official taps because it breaks unattended installation. HTH!

Source: https://twitter.com/MacHomebrew/status/751060331573628929

@guarinogabriel
Copy link
Owner

@romeroabelleira I think we should modify the installation script to not include the wizard.
The wizard could be run with this command: mac config

What are your thoughts?

@romeroabelleira
Copy link

romeroabelleira commented Jul 11, 2016

That sounds perfect. From what I've seen at a glance you'll have to remove git clone, then stuff like at line 81 that depends on a non-homebrew install path and you want to avoid installing homebrew itself :-)

@z11h
Copy link
Contributor

z11h commented Jul 14, 2016

Any news? Haha thanks!

@guarinogabriel
Copy link
Owner

I will close this issue. I decided to prioritize the wizard instead of brew. The wizard is key in order to setup Mac CLI easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants