New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pip and Git #32
Fix pip and Git #32
Conversation
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@@ -543,7 +543,7 @@ elif [ "$function" == "install" ]; then | |||
echo "Installing pip..." | |||
printf "${GREEN}sudo easy_install pip\n${NC}" | |||
sudo easy_install pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be adapted as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the joys of code duplication. Fixed, thanks.
Another thing, when installing Python via brew, does it not come with pip out of the box? |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
I edited the code that was already there and assumed it was doing things correctly, but yes, brew should install pip. @guarinogabriel, perhaps |
get-pip.py
instead of deprecatedeasy_install
Keep up the good work!
(PS. might be nice to clean up indentation and trailing whitespace in the script)