Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip and Git #32

Merged
merged 4 commits into from Jun 28, 2016
Merged

Fix pip and Git #32

merged 4 commits into from Jun 28, 2016

Conversation

Kwpolska
Copy link
Contributor

  1. Fix pip naming (PyPA is the organization behind pip)
  2. Fix GIT → Git spelling (that’s the official way to spell it)
  3. Install pip using get-pip.py instead of deprecated easy_install

Keep up the good work!

(PS. might be nice to clean up indentation and trailing whitespace in the script)

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
mac
@@ -543,7 +543,7 @@ elif [ "$function" == "install" ]; then
echo "Installing pip..."
printf "${GREEN}sudo easy_install pip\n${NC}"
sudo easy_install pip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be adapted as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the joys of code duplication. Fixed, thanks.

@carhartl
Copy link

Another thing, when installing Python via brew, does it not come with pip out of the box?

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@carhartl
Copy link

@Kwpolska
Copy link
Contributor Author

I edited the code that was already there and assumed it was doing things correctly, but yes, brew should install pip. @guarinogabriel, perhaps pip installation should be removed completely and brew install python will take care of things.

@guarinogabriel
Copy link
Owner

@carhartl @Kwpolska – I agree with you. I will merge your PR and I will update the installation commands to use brew install python instead.

Thanks for your contribution!

@guarinogabriel guarinogabriel merged commit 8bdfb8d into guarinogabriel:master Jun 28, 2016
@guarinogabriel
Copy link
Owner

@carhartl @Kwpolska – Actually, the brew install python command is already there. I will remove the pip installation from the install commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants