fix: fixes eslint

.gitignore

@@ -1,3 +1,3 @@
 node_modules
-npm-debug.log
+yarn-error.log
 lib/

package.json

@@ -7,7 +7,7 @@
     "start": "echo 'Not a runnable module' && exit 1",
     "test": "jest",
     "build": "tsc",
-    "lint": "eslint lib test",
+    "lint": "eslint src test",
     "preversion": "npm run lint && npm test"
   },
   "keywords": [
@@ -30,7 +30,8 @@
     "@types/jest": "^27.5.1",
     "@typescript-eslint/eslint-plugin": "^5.27.0",
     "@typescript-eslint/parser": "^5.27.0",
-    "eslint": "^6.7.2",
+    "eslint": "^8.16.0",
+    "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-prettier": "^4.0.0",
     "jest": "^28.1.0",
     "prettier": "^2.6.2",

src/build-filter.ts

@@ -7,19 +7,18 @@ export const buildFilter = (filtersParam: string | string[]) => {
   while (filters.length > 0) {
     const filter = filters.shift();
     filterArray.push(
-      '\\/?' +
-        filter
-          .replace(/\./g, '\\.')
-          .replace(/(\*?)(\*)(?!\*)/g, function (match, prefix) {
-            if (prefix == '*') {
-              return match;
-            }
-            return '[^\\/]*';
-          })
-          .replace(/\?/g, '[^\\/]?')
-          .replace(/\*\*/g, '.*')
-          .replace(/([\-\+\|])/g, '\\$1'),
+      `\\/?${filter
+        .replace(/\./g, '\\.')
+        .replace(/(\*?)(\*)(?!\*)/g, (match, prefix) => {
+          if (prefix === '*') {
+            return match;
+          }
+          return '[^\\/]*';
+        })
+        .replace(/\?/g, '[^\\/]?')
+        .replace(/\*\*/g, '.*')
+        .replace(/([\-\+\|])/g, '\\$1')}`,
     );
   }
-  return new RegExp('^' + filterArray.join('|') + '$', 'i');
+  return new RegExp(`^${filterArray.join('|')}$`, 'i');
 };

src/readfiles.spec.ts

@@ -141,7 +141,7 @@ describe('readfiles', () => {
     });
 
     it("callback returns the relative path of the files when 'filenameFormat' is 'readfiles.RELATIVE'", done => {
-      let count = 0;
+      const count = 0;
       const expectFiles = [
         'abc.txt',
         'abc123.txt',
@@ -170,7 +170,7 @@ describe('readfiles', () => {
     });
 
     it("callback returns only the filename of the file when 'filenameFormat' is 'readfiles.FILENAME'", done => {
-      let count = 0;
+      const count = 0;
       const expectFiles = [
         'abc.txt',
         'abc123.txt',

src/readfiles.ts

@@ -15,12 +15,14 @@ export interface ReadfilesOptions {
   encoding?: BufferEncoding;
 }
 
+type AsyncFunction = (done: () => void) => void;
+
 export type ReadfilesCallback = (
   err: Error | null,
   relativeFilename: string,
   content: string | null,
   stat: fs.Stats,
-) => void | Function;
+) => void | AsyncFunction;
 
 export function readfiles(dir: string): Promise<string[]>;
 export function readfiles(dir: string, callback?: ReadfilesCallback): Promise<string[]>;
@@ -37,6 +39,7 @@ export function readfiles(
     options = {};
   }
   options = options || {};
+  // eslint-disable-next-line @typescript-eslint/no-empty-function
   callback = typeof callback === 'function' ? callback : () => {};
 
   return new Promise((resolve, reject) => {
@@ -45,7 +48,8 @@ export function readfiles(
     const filterRegExp = options.filter && buildFilter(options.filter);
 
     const traverseDir = (dirPath, done) => {
-      fs.readdir(dirPath, (err, fileList) => {
+      fs.readdir(dirPath, (err, fileListProp) => {
+        let fileList = fileListProp;
         if (err) {
           // if rejectOnError is not false, reject the promise
           if (options.rejectOnError !== false) {
@@ -108,7 +112,7 @@ export function readfiles(
               });
             } else if (stat.isFile()) {
               // test filters, if it does not match move to next file
-              if (filterRegExp && !filterRegExp.test('/' + relFilename)) {
+              if (filterRegExp && !filterRegExp.test(`/${relFilename}`)) {
                 return next();
               }
 

test/fs-helper.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import * as fs from 'fs';
 
 const fattenFixtures = (fixtureMap: Record<string, any>, rootPath = '') => {