Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeQL: Incomplete string escaping or encoding @ lib/readfiles.js:13 #9

Closed
ThibaudLopez opened this issue May 19, 2022 · 2 comments
Closed

CodeQL: Incomplete string escaping or encoding @ lib/readfiles.js:13 #9

ThibaudLopez opened this issue May 19, 2022 · 2 comments

Comments

@ThibaudLopez
Copy link
Contributor

ThibaudLopez commented May 19, 2022 •
edited

Hi @guatedude2, following #7 and #8, CodeQL reported another finding (see screenshot below):

  • Title: Incomplete string escaping or encoding.
  • Location: lib/readfiles.js:13
  • Description: Sanitizing untrusted input is a common technique for preventing injection attacks such as SQL injection or cross-site scripting. Usually, this is done by escaping meta-characters such as quotes in a domain-specific way so that they are treated as normal characters.
  • Tool: CodeQL
  • Rule ID: js/incomplete-sanitization

You probably see the same on your CodeQL dashboard.

Is this a true positive or false positive?

Thanks

image
@ThibaudLopez ThibaudLopez mentioned this issue May 19, 2022
Closed
@ThibaudLopez ThibaudLopez changed the title Incomplete string escaping or encoding @ lib/readfiles.js:13 CodeQL: Incomplete string escaping or encoding @ lib/readfiles.js:13 May 19, 2022
@ThibaudLopez ThibaudLopez mentioned this issue May 19, 2022
Merged
@IamGreut IamGreut mentioned this issue May 19, 2022
Closed
2 tasks
@guatedude2
Copy link
Owner

Refactored library to TypeScript

@guatedude2
Copy link
Owner

duplicate of #8

@ThibaudLopez ThibaudLopez mentioned this issue Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guatedude2 @ThibaudLopez