Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL: Useless regular-expression character escape #7

Merged
merged 1 commit into from
May 18, 2022

Conversation

ThibaudLopez
Copy link
Contributor

@ThibaudLopez ThibaudLopez commented May 18, 2022

Fix Code scanning alert:

  • Title: Useless regular-expression character escape
  • File: lib/readfiles.js:21
  • Description:
    The escape sequence '\.' is equivalent to just '.', so the sequence may still represent a meta-character when it is used in a regular expression.
    
  • Tool: CodeQL
  • Rule ID: js/useless-regexp-character-escape

(see also #8 and #9)

Fix Code scanning alert:
- Title: Useless regular-expression character escape
- File: lib/readfiles.js:21
- Description: The escape sequence '\.' is equivalent to just '.', so the sequence may still represent a meta-character when it is used in a regular expression.
- Tool: CodeQL
- Rule ID: js/useless-regexp-character-escape
@guatedude2
Copy link
Owner

Thanks for contributing!

@ThibaudLopez
Copy link
Contributor Author

Hi @guatedude2 . Thanks for accepting the change. Will you merge it? I don't have write access.

@guatedude2 guatedude2 merged commit 9a174c2 into guatedude2:master May 18, 2022
IamGreut added a commit to mapbox/secret-shield that referenced this pull request May 19, 2022
See guatedude2/node-readfiles#7 for discussion on original forked library
@ThibaudLopez ThibaudLopez changed the title Update readfiles.js CodeQL: Useless regular-expression character escape May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants