Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d2sitems/itemdata: remove nolint directive #16

Closed
gucio321 opened this issue May 18, 2021 · 1 comment
Closed

d2sitems/itemdata: remove nolint directive #16

gucio321 opened this issue May 18, 2021 · 1 comment
Assignees
@gucio321
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed lintfix related with lint errors Low Priority nothing urgent, there are more important things

Comments

@gucio321
Copy link
Owner

hmm, this giant nolint directive over the d2sitems/itemdata/item.go looks.... strange
I think, that it should be cut.
IMO gomnd could be left.
@gucio321 gucio321 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Low Priority nothing urgent, there are more important things lintfix related with lint errors labels May 18, 2021
@gucio321
Copy link
Owner Author

generally, I suggest to rewrite this whole
not using global variables

gucio321 added a commit that referenced this issue May 19, 2021
@gucio321
d2sitems/itemdata: create item_code.go with stringer and string2enum …
87aa561 
…directives; remove some of nolint linters in item.go (varcheck, deadcode, unused) (#16)
gucio321 added a commit that referenced this issue May 19, 2021
@gucio321
itemdata: make TomeMap and QuantityMap a methods IsTome and HasQuanti…
0396bcc 
…ty for ItemCode

(#16)
gucio321 added a commit that referenced this issue May 19, 2021
@gucio321
d2smagicattributes: put attributes data from d2sitems/itemdata in d2s…
ef69ae2 
…magicatributes (#16)
gucio321 added a commit that referenced this issue May 19, 2021
@gucio321
d2sitems/itemdata: extract base weapon damage from item.go
fe7b0d6 
(#16)
@gucio321 gucio321 self-assigned this May 19, 2021
gucio321 added a commit that referenced this issue May 19, 2021
@gucio321
Merge pull request #18 from gucio321/itemdata-refactor
27f626f 
refactoring d2sitems/itemdata (should fix #16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gucio321 gucio321

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed lintfix related with lint errors Low Priority nothing urgent, there are more important things
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gucio321