Skip to content

Commit

Permalink
chore: rework externals regex in webpack to support windows (#95)
Browse files Browse the repository at this point in the history
* chore: rework externals regex for windows

* update guess-ga & guess-parser config

* convert c:\\ into c:"
  • Loading branch information
wardpeet authored and mgechev committed May 29, 2019
1 parent 8eacef3 commit 7da91de
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion packages/guess-ga/webpack.config.js
Expand Up @@ -6,7 +6,7 @@ module.exports = {
filename: './guess-ga/index.js',
libraryTarget: 'umd'
},
externals: [/^(@|\w).*$/i],
externals: [/^(@|\w{3}(?<!\w:\\)).*$/i],
resolve: {
// Add `.ts` and `.tsx` as a resolvable extension.
extensions: ['.ts', '.js', '.json']
Expand Down
2 changes: 1 addition & 1 deletion packages/guess-parser/webpack.config.js
Expand Up @@ -6,7 +6,7 @@ module.exports = {
filename: './guess-parser/index.js',
libraryTarget: 'umd'
},
externals: [/^(@|\w).*$/i],
externals: [/^(@|\w{3}(?<!\w:\\)).*$/i],
resolve: {
// Add `.ts` and `.tsx` as a resolvable extension.
extensions: ['.ts', '.js']
Expand Down
4 changes: 2 additions & 2 deletions packages/guess-webpack/webpack.config.js
Expand Up @@ -2,7 +2,7 @@ const CopyWebpackPlugin = require('copy-webpack-plugin');

const common = {
mode: 'production',
externals: [/^(@|\w).*$/i],
externals: [/^(@|\w{3}(?<!\w:\\)).*$/i],
resolve: {
extensions: ['.ts', '.tsx', '.js']
},
Expand All @@ -17,7 +17,7 @@ const common = {
module.exports = [
{
mode: 'production',
externals: [/^(@|\w).*$/i],
externals: [/^(@|\w{3}(?<!\w:\\)).*$/i],
entry: `${__dirname}/api/index.ts`,
output: {
filename: 'api/index.js',
Expand Down

0 comments on commit 7da91de

Please sign in to comment.