Adds guess-static-sites #27
Conversation
There was a problem hiding this comment.
Great work getting these changes in, Katie! I attempted to leave some review comments on 2f43f97, but got an error message from GitHub saying this commit was not part of the PR. It may be a temporary GH issue:
To avoid delaying you, some high-level comments:
-
"After downloading this repo, install the dependencies:" may be worth adding a one-liner before this to git clone
https://github.com/guess-js/guess/andcd experiments\guess-static-sites. Right now if a user clones the repo and runsnpm installin root, they'll install our infra for other packages rather than what they intended :) -
"This repo uses Google Analytics data to determine" - let's switch to "this directory" or "this folder" as it's now part of the main repository.
-
"A client-side script (which you'll add to your application) sends a request to the server to get the URL of the page it should fetch, it then prefetches this resource" I wonder if a casual reader might question what server we're informing them they'll be sending requests to. Perhaps we could expand on this to say "A client-side script (which you'll add to your application) sends a request to the server you are running to get the URL of the page it should fetch, it then.." (or something clearer indicating we aren't asking them to send our servers data).
-
package.json: I wonder if we should rename the
namefield to guess-static-sites-server? or something closer to the newer name now that we have one.
README.md
Outdated
| @@ -18,7 +18,7 @@ Should you wish to try out the modules we offer individually, the `packages` dir | |||
| ***For non-Webpack users:*** | |||
| ### :black_circle: Data-driven loading | |||
|
|
|||
| Our [predictive-fetching for sites](https://github.com/guess-js/guess/tree/predictiveFetching/predictiveFetching) workflow provides a set of steps you can follow to integrate predictive fetching using the Google Analytics API to your site. | |||
| Our [predictive-fetching for sites](https://github.com/guess-js/guess/tree/experiments/guess-static-sites) workflow provides a set of steps you can follow to integrate predictive fetching using the Google Analytics API to your site. | |||
There was a problem hiding this comment.
Minor: https://github.com/guess-js/guess/tree/master/experiments/guess-static-sites as we're merging to master?
|
Excellent suggestions! Fixed. |
No description provided.