Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NOS4A2 to expected options config #607

Closed
wants to merge 1 commit into from
Closed

Added NOS4A2 to expected options config #607

wants to merge 1 commit into from

Conversation

VeNoMouS
Copy link

@VeNoMouS VeNoMouS commented Jun 8, 2019

Python 2.7.13 (default, Sep 26 2018, 18:42:22)
[GCC 6.3.0 20170516] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import guessit
>>> import json
>>> guessit.__version__
'3.0.4'
>>> print json.dumps(
...     guessit.guessit('NOS4A2.S01E01.The.Shorter.Way.REPACK.720p.AMZN.WEB-DL.DDP5.1.H.264-NTG.mkv'),
...     indent=4
... )

{
    "title": "NOS4A2",
    "season": 1,
    "episode": 1,
    "episode_title": "The Shorter Way",
    "other": "Proper",
    "proper_count": 1,
    "screen_size": "720p",
    "streaming_service": "Amazon Prime",
    "source": "Web",
    "audio_codec": "Dolby Digital Plus",
    "audio_channels": "5.1",
    "video_codec": "H.264",
    "release_group": "NTG",
    "container": "mkv",
    "mimetype": "video/x-matroska",
    "type": "episode"
}
>>>

vs without expected title..

{
    "title": "NOS4",
    "season": [
        2,
        1
    ],
    "episode": 1,
    "episode_title": "The Shorter Way",
    "other": "Proper",
    "proper_count": 1,
    "screen_size": "720p",
    "streaming_service": "Amazon Prime",
    "source": "Web",
    "audio_codec": "Dolby Digital Plus",
    "audio_channels": "5.1",
    "video_codec": "H.264",
    "release_group": "NTG",
    "container": "mkv",
    "mimetype": "video/x-matroska",
    "type": "episode"
}

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.014% when pulling fba0935 on VeNoMouS:develop into 1dc0a20 on guessit-io:develop.

@VeNoMouS
Copy link
Author

VeNoMouS commented Jun 8, 2019

@Toilal , @ratoaq2 not sure if you want me to put in a test for this.

@Toilal
Copy link
Member

Toilal commented Jul 23, 2019

It seems more like a bug than a title that should be excluded.

@Toilal
Copy link
Member

Toilal commented Aug 13, 2019

I just found a bug in rebulk that cause this issue, so I won't merge this pull request.

@Toilal Toilal closed this Aug 13, 2019
@VeNoMouS
Copy link
Author

rgr rgr

@Toilal
Copy link
Member

Toilal commented Aug 29, 2019

@VeNoMouS This is fixed in develop branch, which requires rebulk 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants