feat(Streaming Service): Add Max #748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiM-MiM
changed the title
Added MAX to the streaming service list
Decrease amount of false positives for youtube red Currently any thing with "red" it gets youtube red detected as service, and upload script ignores provider if multiple are detected
Updated formatting (spacing)
Make Youtube RED detection case sensitive
Add Support for NOW web service
Toilal
reviewed
Dec 13, 2023
| @@ -734,6 +734,7 @@ | |||
| "ITV": "ITV", | |||
| "Knowledge Network": "KNOW", | |||
| "Lifetime": "LIFE", | |||
| "Max": "MAX", | |||
There was a problem hiding this comment.
Shouldn't this be in "HBO Max" ?
There was a problem hiding this comment.
MAX and HBO MAX are now different streaming services. Which one you get as a customer depends on region, but they have different encodes and selections. https://en.wikipedia.org/wiki/Max_(streaming_service)
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #748 +/- ##
========================================
Coverage 98.46% 98.46%
========================================
Files 52 52
Lines 3454 3454
========================================
Hits 3401 3401
Misses 53 53 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MAX to the streaming service list